Log parsed files to Maven debug log #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
commented
Aug 10, 2023
|
|
||
| @Override | ||
| public void parsed(Parser.Input input, SourceFile sourceFile) { | ||
| progressBar.intermediateResult("Parsed " + input.getPath()); |
There was a problem hiding this comment.
Would we want to add any details here based on the produced SourceFile or ParseError?
There was a problem hiding this comment.
This is incorrect anyway, as it is called after the file is parsed.
jkschneider
requested changes
Aug 10, 2023
|
|
||
| @Override | ||
| public void parsed(Parser.Input input, SourceFile sourceFile) { | ||
| progressBar.intermediateResult("Parsed " + input.getPath()); |
There was a problem hiding this comment.
This is incorrect anyway, as it is called after the file is parsed.
|
Closed as requested while we explore alternatives to report progress instead of logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
We now debug log parsed files through the progress bar interface added to rewrite-all, such that we can optionally swap in a different
What's your motivation?
Fixes #544
Anything in particular you'd like reviewers to focus on?
Right now rewrite-all has runtime only dependencies; do we expect that to stay that way?
If those runtime dependencies change into transitive dependencies that could increase the cumulative runtime size here.
Have you considered any alternatives or workarounds?
This minimal implementation for now only prints parsed files when running the OpenRewrite parsers, as Maven itself already logs the session, projects and mojos. No need to duplicate that here.